feat: prune leftover PlantRun device-registry shells - #99
Merged
Merged
Conversation
Home Assistant refused to delete empty leftover run devices because PlantRun never implemented device removal. Allow registry delete for identifiers that are not in current storage.runs, and drop those shells on setup or reload. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config entry does not support device removal) because the integration never implementedasync_remove_config_entry_device.plantrunidentifiers match a livestorage.runsid, and it prunes those shells on setup/reload via the device registry API.Test plan
python -m unittest discover -s tests -p 'test_*.py'(154 tests)Remaining risk
Reload on the live 0.8.1 install is the actual cleanup. Unit tests cover the registry contract with fakes, not a running Home Assistant.