Conversation
- Update macOS workflow packaging so release archives extract into versioned Yerbas folders instead of the internal build staging directory - Update Windows and Linux workflow packaging so zip and tar artifacts use versioned top-level release folders - Keep CI version selection simple by reading release-version from build.properties and failing loudly when it is missing - Refresh Yerbas icon assets across Qt resources and shared pixmap outputs - Update legacy bitcoin, dash, favicon, ICNS, ICO, PNG, and SVG assets used by launchers, bundles, installers, and Qt resources
- Bump build version for the next `Codex` test build - Fix a reindex crash in ContextualCheckBlock when importing early blocks from blk00000.dat - Guard the median-time-past locktime cutoff so it only calls pindexPrev->GetMedianTimePast when a previous block index exists - Fall back to the current block time when validating genesis or other no-prev-index import cases - Root cause was the reindex/import path allowing pindexPrev to be null while BIPCSV median-time-past logic still attempted to dereference it - Prevents yerbas-loadblk from segfaulting during -reindex in both yerbasd and yerbas-qt - Verified reindex now progresses through historical blocks instead of crashing immediately on blk00000.dat
- Add periodic LoadExternalBlockFile progress logging during block import and reindex - Log the first accepted block, every 1000 accepted blocks, or once per minute during slower import sections - Include loaded block count, resolved height, and block hash in the reindex progress output - Add matching progress logging for recursively processed out-of-order child blocks - Makes long reindex runs visible in debug.log without requiring -debug=reindex - Avoids logging every block so debug.log does not get spammed during full chain rebuilds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This merges the latest Codex work into
dev.3.3.420.71-reindexfrom dereferencing a null previous-block index during median-time-past validationdebug.logRoot cause
During early block import,
ContextualCheckBlock()could receive a nullpindexPrev. When median-time-past locktime rules were active, the code still calledpindexPrev->GetMedianTimePast(), causing an immediate segmentation fault.Validation
debug.log