redundant solved#79
Merged
Merged
Conversation
Owner
|
This branch has merge conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
I have fixed the Redundant Backdrop & Dialog Behavior bug by removing the manual backdrop div and ensuring the native behavior
is used.
🔗 Related Issue
Closes #63
🛠 Changes Made
HTML (index.html)
Removed the manual
Removed
CSS (style.css)
Verified that styling is correctly applied to the native backdrop using the ::backdrop pseudo-element. This ensures the background still
has the desired aesthetic (blur and tint) without needing a separate DOM element.
modal::backdrop{
background: rgba(255,215,230,0.4);
backdrop-filter: blur(5px);
}
JavaScript (app.js)
Verified that the logic for opening and closing the modal correctly uses the native showModal() and close() methods. Since the manual
backdrop was already absent from the JS logic, no changes were needed here, ensuring a clean and direct implementation.
📷 Screenshots (if applicable)
✅ Checklist