feat(fsharp): Ionide-parity code intelligence — code fixes, workspace symbols, interface stubs#124
Merged
Merged
Conversation
… symbols, interface stubs Treat F# as a first-class citizen by closing four FsAutoComplete/Ionide parity gaps, each proven at the sidecar IPC, Rust full-stack, and VSIX interaction layers: - Remove unused `open` quick fix (SLSPF0102 → deletes the open line) [FS-CODEFIX-UNUSEDOPEN] - Simplify name quick fix (SLSPF0103 → strips the redundant qualifier prefix) [FS-CODEFIX-SIMPLIFYNAME] - workspace/symbol for F# — editor "Go to Symbol in Workspace" (Ctrl-T) now finds F# symbols via the FCS sidecar, since the host has no F# tree-sitter grammar [FS-WORKSPACE-SYMBOL] - "Implement interface" code action via FCS InterfaceStubGenerator, completing the union / record / interface stub trio [FS-CODEFIX-INTERFACESTUB] The shared FCS findings (unused opens, simplifiable names) are extracted to FSharpLocalAnalysis.fs so the always-on analyzer hints and the code fixes are computed once and can never diverge. Docs reconciled: FSAC parity matrix + analyzers spec updated; the shipped NuGet-browser implementation plan removed (remaining items tracked in #123); completion auto-open deferred with its blocker documented (#122). Tests: +2 F# sidecar IPC e2e, +1 Rust full-stack e2e, +4 VSIX interaction tests (many interactions and assertions each). Full local suite green: .NET 783, Rust 644, VSIX 1319; coverage ratcheted up across Rust and the VS Code extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F# Ionide-parity code intelligence
Treats F# as a first-class citizen by closing four FsAutoComplete/Ionide parity gaps, each proven at the sidecar IPC, Rust full-stack, and VSIX user-interaction layers. Zero C# feature changes — all F#.
open[FS-CODEFIX-UNUSEDOPEN]openline (theSLSPF0102hint previously had no fix)[FS-CODEFIX-SIMPLIFYNAME]System.DateTime.MinValue→DateTime.MinValue)workspace/symbolfor F#[FS-WORKSPACE-SYMBOL][FS-CODEFIX-INTERFACESTUB]InterfaceStubGenerator, completing the union / record / interface stub trioDRY
Shared FCS findings (unused opens, simplifiable names) extracted to
FSharpLocalAnalysis.fsso the always-on analyzer hints and the code fixes are computed once and can never diverge.Docs
NUGET-BROWSER-SPEC.md; remaining functional items tracked in NuGet browser: finish post-install sidecar workspace reload + prerelease/restore polish #123).opendeferred with its blocker (an unopened-symbol entity index /AssemblyContentProvider) documented in F#: completion auto-openinsertion (FSAC parity) needs an unopened-symbol entity index #122.Tests (F#-weighted, many interactions + assertions each)
SidecarEndToEndTests.fs)tests/e2e_modules/fsharp.rs—test_full_stack_fsharp_workspace_symbol)fsharp-lsp-codefixes.test.ts,fsharp-lsp-workspace-symbol.test.ts)CI prep — full local run, clean first pass (nothing fixed during the pass)
-D warnings), zed, csharpier, dotnet, pack-smoke, prettier, vsix (eslint + tsc) — all greenReferences #122 (auto-open follow-up) and #123 (NuGet remainder) — both kept open as tracking issues.