fix(release): repair startup_failure from invalid continue-on-error on a uses: job#145
Merged
Merged
Conversation
… uses: job continue-on-error is not a valid key on a job that calls a reusable workflow (uses:), so #144 made release.yml fail to start (startup_failure, 0 jobs) on every trigger — including the v0.2.1 re-tag. Move the tolerance to the flyctl Deploy step inside deploy-webcompiler.yml (step-level continue-on-error is valid); the reusable job then succeeds and the release stays green even when the Fly deploy fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
#144 added
continue-on-errorto thedeploy-webcompilerjob, which calls a reusable workflow (uses:). That key is invalid on auses:job, sorelease.ymlfailed to start (startup_failure, 0 jobs) on every trigger. Move the tolerance to the flyctl step.Details
release.yml: removecontinue-on-errorfrom thedeploy-webcompilerjob.deploy-webcompiler.yml: addcontinue-on-error: trueto theDeploy to Fly.iostep. The reusable job then succeeds even if the Fly deploy fails (invalid/banned token), keeping the release green without breaking workflow validity.How Do The Automated Tests Prove It Works?
actionlint+ YAML parse pass; the proof is the re-tagged release run starting (no startup_failure) and ending green with the Fly deploy tolerated.