Skip to content

CW-3261 - Nitro Sign corrupts files created/produced by Aspose #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlasskiy merged 1 commit into from
Feb 25, 2026
Merged

CW-3261 - Nitro Sign corrupts files created/produced by Aspose #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions pdf_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,23 @@ pdf_obj *get_or_create_dict(fz_context *ctx, pdf_obj *parent, pdf_obj *key) {
return dict;
}

// Get the /Resources dictionary for a page, walking up the parent chain if needed.
// If none is found, create a new one on the page and return it.
static inline pdf_obj *get_or_create_resources_dict(fz_context *ctx, pdf_obj *page_obj) {
pdf_obj *resources = pdf_dict_get(ctx, page_obj, PDF_NAME(Resources));
if (resources)
return resources;
pdf_obj *parent = pdf_dict_get(ctx, page_obj, PDF_NAME(Parent));
while (parent) {
resources = pdf_dict_get(ctx, parent, PDF_NAME(Resources));
if (resources)
return resources;
parent = pdf_dict_get(ctx, parent, PDF_NAME(Parent));
}
// None found, create on page
return get_or_create_dict(ctx, page_obj, PDF_NAME(Resources));
}

int page_get_rotation(fz_context *ctx, pdf_page *page) {
int rotation = 0;
rotation = pdf_dict_get_inheritable_int(ctx, page->obj, PDF_NAME(Rotate));
Expand Down Expand Up @@ -272,7 +289,7 @@ void page_add_image(fz_context *ctx, pdf_page *page, fz_image *image, fz_rect po

fz_try(ctx) {
// Add image to Resources
resources = get_or_create_dict(ctx, page->obj, PDF_NAME(Resources));
resources = get_or_create_resources_dict(ctx, page->obj);
xobject = get_or_create_dict(ctx, resources, PDF_NAME(XObject));
image_object = pdf_add_image(ctx, page->doc, image);
if (!image_object) {
Expand Down Expand Up @@ -395,7 +412,7 @@ void page_add_text(fz_context *ctx, pdf_page *page, const char *text, fz_point p
stream = fz_new_buffer(ctx, text_length * 2 + 500);

// Add font to Resources using CID font for full Unicode support
resources = get_or_create_dict(ctx, page->obj, PDF_NAME(Resources));
resources = get_or_create_resources_dict(ctx, page->obj);
font_dict = get_or_create_dict(ctx, resources, PDF_NAME(Font));

// Use CID font (Identity-H encoding) for full Unicode support
Expand Down Expand Up @@ -529,7 +546,7 @@ void page_add_checkbox(fz_context *ctx, pdf_page *page, fz_rect position, int is
if (is_checked) {
// Add Font to Resources
font = fz_new_base14_font(ctx, zapdb_font_name);
resources = get_or_create_dict(ctx, page->obj, PDF_NAME(Resources));
resources = get_or_create_resources_dict(ctx, page->obj);
font_dict = get_or_create_dict(ctx, resources, PDF_NAME(Font));
font_ref = pdf_add_simple_font(ctx, page->doc, font, encoding);
pdf_dict_puts(ctx, font_dict, zapdb_resource_name, font_ref);
Expand Down
Loading