Repository navigation
Warn only about unusual targets, naming the reason, 1.2.1 - #26
Merged
Merged
Conversation
The device picker called any drive with a mounted volume "not ordinary removable media". On Windows every USB stick with a drive letter has one, and so does a desktop-automounted stick on Linux, so ordinary flash drives were flagged. Mounted volumes are expected: the engine unmounts or dismounts them before writing. The warning now appears only for an internal disk, an external hard disk or SSD, or a drive Rufust refuses, and says which. Release as 1.2.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device picker showed " is not ordinary removable media. Check the target before writing." for an ordinary Kingston USB flash drive. Any mounted volume triggered it. On Windows every stick with a drive letter has one, and so does a desktop-automounted stick on Linux. Mounted volumes are expected: the engine unmounts or dismounts them before writing.
The warning now comes from
state::device_warning. It appears only for an internal disk, an external hard disk or SSD, or a drive Rufust refuses (system, boot, swap/page file, RAID/LVM/multi-disk member, read-only, no usable identity), and names the reason. Safety checks and confirmations are unchanged. Tests cover a mounted stick (no warning) and each kind of warning. This PR also releases the fix as 1.2.1.🤖 Generated with Claude Code