Repository navigation
fido2: Add pin config and alwaysUv commands - #819
Open
robin-nitrokey wants to merge 5 commits into
Open
robin-nitrokey wants to merge 5 commits into
robin-nitrokey wants to merge 5 commits into
Conversation
robin-nitrokey
requested review from
daringer,
james-knippes,
mmerklinger and
sosthene-nitrokey
and removed request for
a team
November 16, 2026 21:12
robin-nitrokey
force-pushed
the
set-pin-config
branch
from
November 18, 2026 13:10
e54ecc9 to
8b2a4d8
Compare
robin-nitrokey
force-pushed
the
set-pin-config
branch
from
November 18, 2026 13:18
8b2a4d8 to
56db7ed
Compare
2 tasks
sosthene-nitrokey
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new
fido2subcommands:set-pin-configcorresponds to thesetMinPINLengthsubcommand of theauthenticatorConfigcommand. It would be closer to the standard to call itset-min-pin-length, but I find the name misleading because you can for example set theforceChangePinflag without setting a minimum PIN length.set-always-uvcorresponds totoggleAlwaysUv. I think it’s a better UI to set the flag to an explicit value instead of toggling it.get-always-uvandget-pin-configshow the relevant info. These fields are also present in theget-infooutput but I think it’s easier to find and use if they are also provided by separate commands.