Open
Conversation
prayerie
force-pushed
the
sample-trim
branch
from
43a6948 to
3029248
Compare
asiekierka
reviewed
Nov 19, 2025
arm9/source/main.cpp
Outdated
|
|
||
|
|
||
| if (startsample == endsample) return; | ||
| smp->delPart(1, startsample); |
Collaborator
There was a problem hiding this comment.
Why 1 and not 0? Why startsample and not startsample - 1?
Collaborator
There was a problem hiding this comment.
(Plus, an if (startSample > 0) smp->delPart(0, startsample - 1); makes more sense to me.)
asiekierka
reviewed
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the existing trim icon to crop a sample using
delParttwice (or once if the trim end is also the end of the sample). Also fills the space in nicely.closes #46