Generic builder needs to use baseInputs also#254
Open
lboclboc wants to merge 1 commit into
Open
Conversation
The generic builder only use buildInputs, but the autotools.nix defines baseInputs so the generic builder needs to use both the final packages PATHS (first) and the autotools PATHS (last)
edilmedeiros
reviewed
Mar 8, 2026
| { a = "c"; } | ||
| ``` | ||
|
|
||
| **Exercise:** Complete the new `builder.sh` by adding `$baseInputs` in the `for` loop together with `$buildInputs`. As you noticed, we passed that new variable in the derivation. Instead of merging buildInputs with the base ones, we prefer to preserve buildInputs as seen by the caller, so we keep them separated. Just a matter of choice. |
There was a problem hiding this comment.
Doesn't seem relevant since this line asks the reader to write the fix as an exercise. First version of the script is correct, baseIputs (the bug) is introduced in the second version, right before the exercise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic builder only use buildInputs, but the autotools.nix defines baseInputs so the generic builder needs to use both the final packages PATHS (first) and the autotools PATHS (last)