Skip to content

glfw: 3.3.10 -> 3.4 - #293306

Closed
Scrumplex wants to merge 2 commits into
NixOS:masterfrom
Scrumplex:pkgs/glfw/bump-3.4
Closed

glfw: 3.3.10 -> 3.4#293306
Scrumplex wants to merge 2 commits into
NixOS:masterfrom
Scrumplex:pkgs/glfw/bump-3.4

Conversation

@Scrumplex

Copy link
Copy Markdown
Member

Description of changes

https://github.com/glfw/glfw/releases/tag/3.4

GLFW's wayland implementation is fairly robust now, which means we should be able to drop the separate wayland packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
The game works fine with upstream glfw 3.4 now.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@getchoo

getchoo commented Mar 4, 2024

Copy link
Copy Markdown
Member

duplicate of #293296

@Scrumplex Scrumplex closed this Mar 14, 2024
@Scrumplex
Scrumplex deleted the pkgs/glfw/bump-3.4 branch September 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants