Skip to content

python311Packages.distrax: fix type errors#300648

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
stephen-huan:distrax-fix
Oct 28, 2024
Merged

python311Packages.distrax: fix type errors#300648
GaetanLepage merged 1 commit intoNixOS:masterfrom
stephen-huan:distrax-fix

Conversation

@stephen-huan
Copy link
Copy Markdown
Member

Description of changes

As mentioned in #297146 (comment), an update to chex breaks some of distrax's tests.

This PR is a stopgap measure to fix the build until this PR to distrax lands.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 1, 2024
@stephen-huan stephen-huan changed the title distrax: fix type errors caused by chex in tests python311Packages.distrax: fix type errors caused by chex in tests Apr 1, 2024
@stephen-huan stephen-huan changed the title python311Packages.distrax: fix type errors caused by chex in tests python311Packages.distrax: fix type errors Apr 1, 2024
@ofborg ofborg bot requested a review from onny April 1, 2024 09:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 1, 2024
@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 300648


x86_64-linux

✅ 4 packages built:
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist

aarch64-linux

✅ 4 packages built:
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist

x86_64-darwin


aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist

@GaetanLepage GaetanLepage merged commit 28595cc into NixOS:master Oct 28, 2024
@stephen-huan stephen-huan deleted the distrax-fix branch October 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants