Skip to content

glfw-wayland-minecraft: drop - #306827

Closed
Scrumplex wants to merge 2 commits into
NixOS:masterfrom
Scrumplex:pkgs/glfw-wayland-minecraft/remove
Closed

glfw-wayland-minecraft: drop#306827
Scrumplex wants to merge 2 commits into
NixOS:masterfrom
Scrumplex:pkgs/glfw-wayland-minecraft/remove

Conversation

@Scrumplex

@Scrumplex Scrumplex commented Apr 25, 2024

Copy link
Copy Markdown
Member

Description of changes

The patches applied in this package are no longer useful, as GLFW 3.4 shipped in glfw3 works fine in Minecraft.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
The patches applied in this package are no longer useful, as GLFW 3.4
shipped in glfw3 works fine in Minecraft.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex

Copy link
Copy Markdown
Member Author

Result of nixpkgs-review pr 306827 run on x86_64-linux 1

2 packages built:
  • prismlauncher
  • prismlauncher-qt5

@ofborg ofborg Bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 25, 2024
@oxalica

oxalica commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

GLFW 3.4 shipped in glfw3 works fine in Minecraft.

It does not for me (KDE wayland). It starts fine but easily break on some events, see #293296 (comment) and also #306264

@Scrumplex

Copy link
Copy Markdown
Member Author

In that case, let's keep it for now!

@Scrumplex Scrumplex closed this Apr 27, 2024
@Scrumplex
Scrumplex deleted the pkgs/glfw-wayland-minecraft/remove branch September 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants