rocmPackages: 7.1.1 -> 7.2.0 by LunNova · Pull Request #484792 · NixOS/nixpkgs

LunNova · 2026-01-28T17:12:33Z

Issues encountered so far:

Broken standalone clang build due to emissary changes
- Worked around version in ROCm repo as it differs from the one that will be upstreamed, reviewed upstream PR [OpenMP] support for Emissary APIs as discussed in 89169 llvm/llvm-project#175265 to try to make sure it doesn't cause standalone build issues
~~Missing tags for some repos~~
- rocMLIR Wrong tag format for 7.2.0: "rocm7.2" instead of "rocm-7.2.0" ROCm/rocMLIR#2218
- rocsolver
- hipsolver
Backported fix for loop unrolling perf issues [Issue]: ROCm 7+ Performance regression on llama.cpp ROCm/rocm-systems#2865 Revert "AMDGPU: Fix runtime unrolling when cascaded GEPs present (#147700) ROCm/llvm-project#1349

Eval diff

5f83595 (+0 -0 ~79 ) rocmPackages.llvm: use clang config file instead of deprecated GCC_INSTALL_PREFIX
691e492 (+0 -0 ~92 ) rocmPackages: 7.1.1 -> 7.2.0
331070f (+0 -0 ~82 ) rocmPackages.llvm: revert loop unrolling pessimisation
3376d1e (+0 -0 ~0 ) rocmPackages.miopen: add updateScript for DVC S3 kdb files
3bc0e6a (+0 -0 ~0 ) rocmPackages: sha256 = -> hash =

Things done

eiis1000 · 2026-02-23T05:02:49Z

Given the post-closure discussion in #481349, might this update resolve the sporadic OOM failures of e.g. #492098?

GZGavinZhao · 2026-02-24T22:09:59Z

Rebased ISA compatibility patches:

…STALL_PREFIX

LunNova · 2026-03-01T05:48:06Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 484792 --skip-package-regex python313Packages.*
Commit: b12ea8cb051cccd6744ed31b0ca8328f89b3efc3

`x86_64-linux`

✅ 109 packages built:

adaptivecpp
adaptivecppWithCuda
adaptivecppWithRocm
btop-rocm
llama-cpp-rocm
llama-cpp-rocm.dev
magma (magma-hip)
magma.test (magma-hip.test)
ollama-rocm
opensplatWithRocm
python314Packages.amdsmi
python314Packages.torchWithRocm
python314Packages.torchWithRocm.cxxdev
python314Packages.torchWithRocm.dev
python314Packages.torchWithRocm.dist
python314Packages.torchWithRocm.lib
rocmPackages.amdsmi
rocmPackages.aotriton
rocmPackages.aotriton.debug
rocmPackages.aqlprofile
rocmPackages.ck4inductor
rocmPackages.ck4inductor.dist
rocmPackages.clang (rocmPackages.llvm.clang, rocmPackages.llvm.rocm-toolchain, rocmPackages.rocm-toolchain)
rocmPackages.clr
rocmPackages.clr.debug
rocmPackages.clr.icd
rocmPackages.composable_kernel
rocmPackages.half
rocmPackages.hip-common
rocmPackages.hipblas
rocmPackages.hipblas-common
rocmPackages.hipblaslt
rocmPackages.hipblaslt.benchmark
rocmPackages.hipcc
rocmPackages.hipcub
rocmPackages.hipfft
rocmPackages.hipfort
rocmPackages.hipify
rocmPackages.hiprand
rocmPackages.hiprt
rocmPackages.hipsolver
rocmPackages.hipsparse
rocmPackages.hsakmt (rocmPackages.rocm-runtime)
rocmPackages.hsakmt.debug (rocmPackages.rocm-runtime.debug)
rocmPackages.llvm.bintools
rocmPackages.llvm.clang-unwrapped
rocmPackages.llvm.clang-unwrapped.debug
rocmPackages.llvm.clang-unwrapped.dev
rocmPackages.llvm.clang-unwrapped.lib
rocmPackages.llvm.clang-unwrapped.python
rocmPackages.llvm.compiler-rt (rocmPackages.llvm.compiler-rt-libc)
rocmPackages.llvm.compiler-rt.dev (rocmPackages.llvm.compiler-rt-libc.dev)
rocmPackages.llvm.libcxx
rocmPackages.llvm.libcxx.dev
rocmPackages.llvm.lld
rocmPackages.llvm.lld.dev
rocmPackages.llvm.lld.lib
rocmPackages.llvm.llvm
rocmPackages.llvm.llvm.dev
rocmPackages.llvm.llvm.lib
rocmPackages.llvm.llvm.python
rocmPackages.openmp (rocmPackages.llvm.openmp)
rocmPackages.openmp.dev (rocmPackages.llvm.openmp.dev)
rocmPackages.stdenv (rocmPackages.rocmClangStdenv)
rocmPackages.migraphx
rocmPackages.miopen (rocmPackages.miopen-hip)
rocmPackages.mivisionx (rocmPackages.mivisionx-hip)
rocmPackages.mivisionx-cpu
rocmPackages.mpi (rocmPackages.openmpi)
rocmPackages.mpi.dev (rocmPackages.openmpi.dev)
rocmPackages.mpi.man (rocmPackages.openmpi.man)
rocmPackages.mscclpp
rocmPackages.rccl
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages.rocalution
rocmPackages.rocblas
rocmPackages.rocblas.benchmark
rocmPackages.rocblas.test
rocmPackages.rocdbgapi
rocmPackages.rocdbgapi.doc
rocmPackages.rocfft
rocmPackages.rocgdb
rocmPackages.rocm-bandwidth-test
rocmPackages.rocm-cmake
rocmPackages.rocm-comgr
rocmPackages.rocm-core
rocmPackages.rocm-device-libs
rocmPackages.rocm-smi
rocmPackages.rocm-tests
rocmPackages.rocminfo
rocmPackages.rocmlir (rocmPackages.rocmlir-rock)
rocmPackages.rocprim
rocmPackages.rocprofiler
rocmPackages.rocprofiler-register
rocmPackages.rocr-debug-agent
rocmPackages.rocrand
rocmPackages.rocsolver
rocmPackages.rocsparse
rocmPackages.rocthrust
rocmPackages.roctracer
rocmPackages.rocwmma
rocmPackages.rpp (rocmPackages.rpp-hip)
rocmPackages.rpp-cpu
rocmPackages.tensile
rocmPackages.tensile.dist
stable-diffusion-cpp-rocm
stable-diffusion-cpp-rocm.dev
zluda

@GZGavinZhao

Thanks @GZGavinZhao for providing continued support in the form of the ISA compat patch set. Co-Authored-By: Gavin Zhao <git@gzgz.dev>

Reverting a patch that caused terrible performance for some large langle mangle workloads. See also rocm-systems issue 2865 and rocm llvm-project pull 1349

Files were moved to DVC in rocm-libraries PR 1594

06kellyjac

2 packages with an update but no hash change, just need to double check nothing actually changed there & is a bump in name only.

A few nits on sha256 -> hash but not very important.

Looks very good. I'll get a build going later 🙂

LunNova · 2026-03-02T16:14:21Z

Specifically calling out this DVC stuff as odd, is there a nicer approach I'm missing than this script and the generated kdbs file full of s3 paths?

Flakebi

Changes look good to me (though @06kellyjac left some good comments).
Thanks for your tremendous effort on these updates!

LunNova · 2026-03-02T17:35:48Z

Applied a rocm-modules wide swap from sha256 = to hash =, no additional rebuilds.

woile

I built some of the packages on my system with no errors

nix build 'github:LunNova/nixpkgs/3bc0e6a4c5fc9c8652694b0eaccebd8b1c419f5e#rocmPackages.amdsmi'

nix build 'github:LunNova/nixpkgs/3bc0e6a4c5fc9c8652694b0eaccebd8b1c419f5e#rocmPackages.clr'

thanks for the titanic work 💪🏻 🎉

azahi · 2026-03-07T11:05:56Z

rocmPackages.hipblaslt failed to build on Hydra again https://hydra.nixos.org/build/323310565. Is it related to the version bump or these are some kind of OOM shenanigans again?

musjj · 2026-03-07T12:58:40Z

It seems that the error is propagated from: https://hydra.nixos.org/build/323309073.

So it's a problem with the torch-no-triton dependency?

nyabinary · 2026-03-07T13:45:46Z

rocmPackages.hipblaslt failed to build on Hydra again https://hydra.nixos.org/build/323310565. Is it related to the version bump or these are some kind of OOM shenanigans again?

If it's OOM again this is a pretty annoying issue that should be fixed tbh. My laptop can't handle building hipblaslt :(

LunNova · 2026-03-07T14:31:26Z

it's not an oom in hipblaslt this time. the source tree exceeds the output limit. new hipblaslt failure mode! :(

LunNova · 2026-03-07T14:51:40Z

rocmPackages.hipblaslt.src: compress yaml in postFetch to meet output limit #497589

LunNova · 2026-03-07T15:38:53Z

If it's OOM again this is a pretty annoying issue that should be fixed tbh. My laptop can't handle building hipblaslt :(

About the OOMs: hipblaslt's tensilelite build system needs a rewrite or significant rearchitecture, upstream are working on it but no timeline, I've done the best that I can with the resources I have available in the patch set we carry.

I'm sorry about the trouble it causes.

This reverts commit 5fab99f, reversing changes made to 9c0a490.

LunNova linked an issue Jan 28, 2026 that may be closed by this pull request

Update Request: rocmPackages 7.1.1 → 7.2.0 #484525

Closed

3 tasks

LunNova force-pushed the lunova/rocm-7.2 branch 2 times, most recently from 410df74 to a74ad69 Compare January 31, 2026 00:23

cryptk mentioned this pull request Feb 10, 2026

Update Request: rocmPackages 7.1.1 → 7.2.0 #484525

Closed

3 tasks

LunNova force-pushed the lunova/rocm-7.2 branch from a74ad69 to dbca05e Compare February 28, 2026 18:16

nixpkgs-ci Bot added the 8.has: package (update) This PR updates a package to a newer version label Feb 28, 2026

LunNova force-pushed the lunova/rocm-7.2 branch from a69b7fa to a7b66ca Compare March 1, 2026 00:31

rocmPackages.llvm: use clang config file instead of deprecated GCC_IN…

5f83595

…STALL_PREFIX

LunNova force-pushed the lunova/rocm-7.2 branch from a7b66ca to b12ea8c Compare March 1, 2026 05:42

LunNova marked this pull request as ready for review March 1, 2026 05:48

LunNova and others added 3 commits February 28, 2026 21:51

rocmPackages: 7.1.1 -> 7.2.0

691e492

Thanks @GZGavinZhao for providing continued support in the form of the ISA compat patch set. Co-Authored-By: Gavin Zhao <git@gzgz.dev>

rocmPackages.llvm: revert loop unrolling pessimisation

331070f

Reverting a patch that caused terrible performance for some large langle mangle workloads. See also rocm-systems issue 2865 and rocm llvm-project pull 1349

rocmPackages.miopen: add updateScript for DVC S3 kdb files

3376d1e

Files were moved to DVC in rocm-libraries PR 1594

LunNova force-pushed the lunova/rocm-7.2 branch from b12ea8c to 3376d1e Compare March 1, 2026 05:51

nixpkgs-ci Bot requested review from a team and lovesegfault March 1, 2026 05:57

06kellyjac reviewed Mar 2, 2026

View reviewed changes

LunNova commented Mar 2, 2026

View reviewed changes

Flakebi reviewed Mar 2, 2026

View reviewed changes

rocmPackages: sha256 = -> hash =

3bc0e6a

LunNova requested a review from 06kellyjac March 2, 2026 17:51

Flakebi approved these changes Mar 3, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 3, 2026

woile approved these changes Mar 3, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 3, 2026

LunNova added this pull request to the merge queue Mar 5, 2026

Merged via the queue into NixOS:master with commit 5fab99f Mar 5, 2026
35 of 37 checks passed

LunNova deleted the lunova/rocm-7.2 branch March 5, 2026 13:47

LunNova mentioned this pull request Mar 5, 2026

python3Packages.amdsmi: 7.1.1 -> 7.2.0 #491282

Closed

gaelj added a commit to gaelj/nixpkgs that referenced this pull request Mar 8, 2026

Revert "rocmPackages: 7.1.1 -> 7.2.0 (NixOS#484792)"

48d5ec9

This reverts commit 5fab99f, reversing changes made to 9c0a490.

gaelj added a commit to gaelj/nixpkgs that referenced this pull request Mar 9, 2026

Revert "rocmPackages: 7.1.1 -> 7.2.0 (NixOS#484792)"

e10fe65

This reverts commit 5fab99f, reversing changes made to 9c0a490.

frozolotl mentioned this pull request Mar 26, 2026

blender: 5.0.1 -> 5.1.0 #502842

Merged

13 tasks

Uh oh!

Uh oh!

Conversation

LunNova commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

eiis1000 commented Feb 23, 2026

Uh oh!

GZGavinZhao commented Feb 24, 2026

Uh oh!

LunNova commented Mar 1, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

06kellyjac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LunNova Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Flakebi left a comment

Choose a reason for hiding this comment

Uh oh!

LunNova commented Mar 2, 2026

Uh oh!

woile left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azahi commented Mar 7, 2026

Uh oh!

musjj commented Mar 7, 2026

Uh oh!

nyabinary commented Mar 7, 2026

Uh oh!

LunNova commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LunNova commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LunNova commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

LunNova commented Jan 28, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

woile left a comment •

edited

Loading

LunNova commented Mar 7, 2026 •

edited

Loading

LunNova commented Mar 7, 2026 •

edited

Loading

LunNova commented Mar 7, 2026 •

edited

Loading