Conversation
|
This comment was marked as duplicate.
This comment was marked as duplicate.
|
I opened OSGeo/gdal#14127 for the gdalMinimal failure. |
|
And #499843 to fix gdal build with this MR. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
We have a problem with pyproj not supporting this version of proj yet, apparently. |
|
@dotlambda a fix for pyproj: autra@a58873a |
This comment was marked as outdated.
This comment was marked as outdated.
|
527b2e6 to
b630067
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
|
For cartopy, upstream seems to be thinking about some fixes, but that can take some time. Tracking issue is probably this one. |
|
Should we merge anyway? This is the unstable branch after all. |
I'm torn on this. In one hand, it'll allow us to move forward. On the other hand, this version seems to be a pretty big change (in unit tests), and it will take some time for those projects to adapt. Yes unstable can be broken, but it should be a temporary state before a fix imo. Here it can take weeks. I'd still wait a bit (actively, by raising issues upstream). Other possibilities:
Maybe just disabling failing tests would be the best way to move forward in order not to completely block unstable users. |
|
Very strange: mod_tiles failed here, but succeed locally... |
I would wait 2 more weeks if things settle more. |
|
I agree with the general principle to merge and move on, but if the downstream tests are working on updating, a small delay seems reasonable to me. |
|
Now, I think we should check again and see. It's been 2 weeks already. We'll need it before ZHF anyway, right? Btw, does this constitute a blocker for next nixos release? |
Why? |
Well, I thought it was better to break things before this period, when you're supposed to fix things. Also, during ZHF, people may be more proactive to fix other dependant projects. Also I think it'd be nice to have it in NixOS 26.05. None of those are really deal-breakers though, because I guess we can still backport later. |
|
There's now a PR fixing cartopy: SciTools/cartopy#2653 |
This comment was marked as outdated.
This comment was marked as outdated.
|
autra
left a comment
There was a problem hiding this comment.
The only package really broken by this MR is cartopy, the others are already broken on master. I think we should merge now and fix this one later :-)
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/OSGeo/PROJ/releases.
meta.description for proj is: Cartographic Projections Library
meta.homepage for proj is: https://proj.org/
meta.changelog for proj is: https://github.com/OSGeo/PROJ/blob/9.8.0/NEWS.md
Updates performed
To inspect upstream changes
Impact
Checks done
Caution
A test defined in
passthru.testsdid not pass.Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-review --extra-nixpkgs-config '{ allowBroken = false; }'Commit:
83930ae45fdb2a745e9964215faceb8a0645690dx86_64-linux❌ 325 packages failed to build:
✅ 18 packages built:
Maintainer pings
cc @dotlambda @imincik @autra @l0b0 @nh2 @nialov @sikmir @willcohen for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this update using thenixpkgs-merge-bot.