Skip to content

perlPackages.CPAN: fix build, patch url content has changed#81480

Closed
stigtsp wants to merge 1 commit intoNixOS:masterfrom
stigtsp:package/perl-cpan-yaml-patch-update
Closed

perlPackages.CPAN: fix build, patch url content has changed#81480
stigtsp wants to merge 1 commit intoNixOS:masterfrom
stigtsp:package/perl-cpan-yaml-patch-update

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 2, 2020 •
edited
Loading

ZHF: #80379

The LoadBlessed patch in #80471 was included from a GitHub PR without a commit reference, and the contents have changed.

Updated the patch from the merged PR, and stored as a file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
perlPackages.CPAN: fix build, patch url content was changed
558bc8a 
The LoadBlessed patch in PR 80471 was included from a GitHub PR
without a commit reference, and the contents have changed.

Updated the patch from the merged PR, and stored as a file.
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 2, 2020
@veprbl veprbl closed this in fa73723 Mar 27, 2020
veprbl added a commit that referenced this pull request Mar 27, 2020
@veprbl
perlPackages.CPAN: fix patch download
5ffc821 
Fixes: 153b0db ('perlPackages.CPAN: apply patch to fix changed YAML module default')
Closes: #81480
(cherry picked from commit fa73723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stigtsp