Skip to content

fix(release): name the repository for gh in the Homebrew publish job - #559

Merged
wchwawa merged 1 commit into
mainfrom
fix/homebrew-publish-gh-repo
Oct 21, 2026
Merged

wchwawa merged 1 commit into
mainfrom
fix/homebrew-publish-gh-repo

Conversation

@wchwawa

@wchwawa wchwawa commented Oct 21, 2026

Copy link
Copy Markdown
Member

Related Issue

No issue: this is a release-tooling chore, which the template exempts. It follows #558 and still blocks the Homebrew half of the 0.12.0 release.

Summary

  • fix(release): add Homebrew assets to a release that already exists #558 made the Homebrew publish step run from the release directory, outside the checkout. gh infers the repository from git when none is named, so the v0.12.0 rerun failed with not a git repository (run 39567616293).
  • Nothing was written in that run. Its failed gh release view sent it down the create branch, and the create then failed as well.
  • The job now sets GH_REPO: ${{ github.repository }}, as the Python SDK publish job already does. The workflow test requires it.

Scope

  • This PR changes one logical boundary only.
  • No unrelated refactor, benchmark, metadata model, Holt layout,
    object-store, agent interface, or docs change is mixed in.
  • The linked issue describes the user-visible problem, design decision, or
    maintenance task this PR resolves (release chore; see above).
  • Any breaking change is intentional and documented (none).
  • No compatibility shim, deprecated alias, or forwarding wrapper was added without a removal condition.

Change Size And Review

  • I checked GitHub's additions plus deletions for this pull request.
  • If the total is more than 5,000 lines, one core maintainer other than the
    current-head pusher approved the exact current head commit. Not applicable: under 5,000 lines.
  • This change is still small enough for a focused review; approval count is
    not being used to justify mixed package or lifecycle boundaries.

Code Contract (Code Changes Only)

  • Not applicable; this is a docs/config-only change.

Claims and Evidence

  • User-facing documentation distinguishes current, experimental, and
    planned capabilities (no documentation change).
  • Security claims do not treat a Workbench root or Agent scope as tenant
    authentication or authorization (no security claims).
  • Performance claims state the topology, comparison boundary, cache state,
    run count, and raw-evidence location (no performance claims).
  • Benchmark-only behavior does not alter product semantics.

Validation

  • Command and result: python3 scripts/release/test_homebrew_source_release.py passes, and the workflow YAML parses.
  • Not run (with reason): the publish path itself. It runs when the Homebrew release is dispatched again for v0.12.0 after this merges.

Contributor Sign-off

  • Every commit in this PR includes a DCO Signed-off-by trailer.

The publish step now works from the release directory, outside the
checkout, so gh could no longer infer the repository from git and the
v0.12.0 rerun failed with "not a git repository". Set GH_REPO for the
job, as the Python SDK publish job already does.

Signed-off-by: wchwawa <wch19961116@gmail.com>
@wchwawa
wchwawa requested a review from feichai0017 as a code owner October 21, 2026 08:27
@feichai0017 feichai0017 moved this to In Progress in NoKV Delivery Oct 21, 2026
@wchwawa
wchwawa merged commit a9223e1 into main Oct 21, 2026
9 checks passed
@wchwawa
wchwawa deleted the fix/homebrew-publish-gh-repo branch October 21, 2026 08:36
@github-project-automation github-project-automation Bot moved this from In Progress to Done in NoKV Delivery Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants