Repository navigation
fix(release): name the repository for gh in the Homebrew publish job - #559
Merged
Merged
Conversation
The publish step now works from the release directory, outside the checkout, so gh could no longer infer the repository from git and the v0.12.0 rerun failed with "not a git repository". Set GH_REPO for the job, as the Python SDK publish job already does. Signed-off-by: wchwawa <wch19961116@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue: this is a release-tooling chore, which the template exempts. It follows #558 and still blocks the Homebrew half of the 0.12.0 release.
Summary
ghinfers the repository from git when none is named, so the v0.12.0 rerun failed withnot a git repository(run 39567616293).gh release viewsent it down the create branch, and the create then failed as well.GH_REPO: ${{ github.repository }}, as the Python SDK publish job already does. The workflow test requires it.Scope
object-store, agent interface, or docs change is mixed in.
maintenance task this PR resolves (release chore; see above).
Change Size And Review
current-head pusher approved the exact current head commit. Not applicable: under 5,000 lines.
not being used to justify mixed package or lifecycle boundaries.
Code Contract (Code Changes Only)
Claims and Evidence
planned capabilities (no documentation change).
authentication or authorization (no security claims).
run count, and raw-evidence location (no performance claims).
Validation
python3 scripts/release/test_homebrew_source_release.pypasses, and the workflow YAML parses.Contributor Sign-off
Signed-off-bytrailer.