Repository navigation
Conversation
Nocehi
force-pushed
the
feat/rail-surface-morph-prototype
branch
from
August 17, 2026 01:35
021658b to
59c5b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Replace the rejected long-distance rail→switcher goo experiment with a narrower presentation prototype: only genuinely local source→surface relationships may read as continuous.
dsh-ricemust not manufacture a tentacle across the interface.The ordinary geometry gate is one application-rail width: 56px edge-to-edge.
What this now experiments with
1. Stable accessible source→target relations
The core
src/surface-morph.jspath remains standards-first:[aria-controls][aria-expanded]→ visible controlled target;<details><summary>→ opened content;<= 56px;ResizeObserver+ mutation/scroll/resize refresh;This is the preferred path for Todo/collapsed-card style disclosures. If the live host does not expose a durable accessible relationship, rice stays silent rather than guessing a private class/React seam.
2. Newly-visible nearby semantic popups
src/surface-morph-candidates.jsadds a second standards-based candidate path for controls whose popup semantics live on the newly-mounted surface rather than onaria-controls:button,[role=button], or[aria-haspopup]activation;role=menu,role=listbox,role=dialog, or open native popover surfaces;This is intended to dogfood nearby composer action menus/pickers and the dsh-better-sidebar tab-bar
+menu without adding a private selector map.3. dsh-better-sidebar right-workbench corner bloom
The sidebar target here is specifically
omdsh-dev/DSH-better-sidebar, while all implementation remains in dsh-rice.The public
betterSidebarclient service is authoritative: rice injects it, readsgetSnapshot().state, and subscribes withsubscribeState(). Existing root hooks still mirror public side/bottom/open/size/maximize state.The new candidate adapter adds a visual experiment for the right workbench only without querying any Better Sidebar CSS-module class:
panelOpentransition within the freshness window to prove that activation belonged to the right workbench toggle;panelOpen: true → false;prefers-reduced-motion: reducesuppresses the bloom;pointer-events:none,aria-hidden, and never replaces the real workbench DOM.The bottom workbench deliberately does not get this bloom: its top-right toggle and bottom destination are spatially non-local and would recreate the rejected tentacle topology.
There is no
.dsh-better-sidebarselector, CSS-module substring match, vendored implementation, or modification to the Better Sidebar repository.Todo / Produced / composer / collapsed-card dogfood paths
betterSidebar.openTab(...). This is intentionally a locality negative/conditional test: if the real destination is far across the conversation viewport, rice should draw nothing rather than force a cross-viewport transition.+: if the DSH Menu surface mounts semantically and within 56px, it should get only the tiny local bridge.Acceptance / dogfood questions
+menu get a tiny local connector when its real semantic menu is nearby, and release cleanly on close?Implementation boundary
No new runtime package is added.
src/surface-morph.jsandsrc/surface-morph-candidates.jsremain dependency-free scripts concatenated into the existing browser artifact; the generated client still allows only the existing React and DSH UI-primitives requires.Focused tests cover the 56px locality gate, semantic popup discovery, observer lifecycle, Better Sidebar public-service gating, top-right locality/freshness, 180ms reversible bloom, reduced motion, pointer-inert presentation, absence of private sidebar selectors, and build purity.
Exact-head CI on
dda1f9227f96837bbf492c5fd7c8657346d94b90is green (check run #199). Physical dogfood remains the visual merge gate.