Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MIPS PIC shared objects, an import call drops the arguments its declaration states, the first import is called by its section label, and the last lazy-binding stub cannot be decompiled:
Current output, excerpted:
Fix
gotimportproto, a call that the loader proves goes through an import's GOT entry takes that import's declared prototype.len_plus_onenow returnsstrlen(a0) + 1. Other indirect calls still need a declaration with explicit storage._MIPS_STUBS_, the section label at the same address, sothen_storecallstransform(). The label stays an alias..MIPS.stubsentry's instructions, GOT slot and dynamic-symbol index, and records its resolver call. Withstubtailcall, flow ends the stub with that call as a tail call, and function discovery stops there instead of running into the next stub or past the section. Thestrlenstub now decompiles asreturn (*v1)();.offrestores the current flow and prototypes.Tests
kuna xrefs, and that declared imports keep their arguments. x86-64 and PE controls show other indirect calls are unchanged.