Repository navigation
ci(stable): accept apksigner digest labels without weakening the fingerprint check - #18
Merged
Merged
Conversation
Noirero
marked this pull request as ready for review
November 13, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run #43358461417 built all three APKs, then rejected a matching certificate because apksigner printed
V2 Signer:instead ofSigner #1.Update the same parser in both Stable workflows. Keep apksigner verification and the pinned fingerprint. Require at least one valid 64-hex certificate SHA-256 digest and reject any different or malformed reported certificate digest. No changes to secrets, triggers, publication, or app source.
Local Bash fixtures passed: V2 label, legacy numbered label with uppercase digest, matching V2/V3, missing SHA-256, wrong digest, extra characters, and mixed digests. After CI/review and integration, freshly dispatch only
Fiyora Stable Candidate (manual)frommain; rerunning the old run would reuse its old SHA.