Repository navigation
feat(ui): pilot Modern navigation and Library geometry - #42
Merged
Merged
Conversation
Noirero
marked this pull request as ready for review
November 14, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply scoped Modern geometry to phone navigation and Library headers, categories, search/filter controls, covers and list thumbnails while retaining Lalapo palettes, artwork, preset shapes, column preferences and callbacks.
Each Modern Library action has one click/focus/semantics owner with a minimum 48dp touch area. Its shaped visual child keeps a 34dp minimum and grows for wrapped or scaled text. Add regressions for edge taps, neighbouring controls, selected semantics, narrow/large-font layouts, the independent Source filter dialog, before/after grid breakpoints and the authored Lalapo cover outline. Emulator tests configure and restore a 432×768dp display; narrow cases use a 320dp component container.
Local validation for HEAD
3309c76155f0c93b0d073ae5c50c08a680668a0a:spotlessCheck: PASS.:app:compileDebugKotlin: PASS for the unchanged production content inf312d1e78799c4870e9e93bfd1a2600be6612eff.:app:compileDebugAndroidTestKotlin: PASS after the test-only follow-up.:app:testDebugUnitTestwith the theme and Library component filters plusAnimeModernThemeIntegrationTest: 44 targeted tests PASS; zero failures, errors or skips after the follow-up.CI on that exact HEAD (run 43606680907):
connectedDebugAndroidTestfinished 30 tests on the API 35 emulator, including the eight new UI cases; no UI test failure or skip was reported.Android tests were not executed locally. Paired before/after screenshots, effective navigation/inset measurements, runtime crop comparisons and physical-device testing remain outstanding. Browse divider, Library sheet and badge behavior are unchanged. Visual parity remains unverified; keep this PR Draft.