Repository navigation
Fix APK versionCode allocation after GitHub run ID overflow - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Run 43651042254 failed before Gradle: the old run-ID offset produced 2651042254, above 2100000000.
Change
Require an explicit decimal version_code for Beta and Stable manual builds. Tag builds read the repository variable LALAPO_RELEASE_VERSION_CODE. All three fail closed outside (2031852413, 2100000000]. Floor is the highest versionCode observed in successful archived workflow logs (Stable run 43031852413; Beta run 43027663597 used 2027663597). No signing, package or upload changes.
Distribution procedure
Before distributing, verify the highest versionCode actually shipped for the same applicationId and allocate a fresh higher value; the floor is not a registry and does not prevent reuse. For tagged release, set LALAPO_RELEASE_VERSION_CODE before the tag is pushed and allocate a new value for each release. Stable and tag workflows take effect only on refs containing this fix. Do not test via a publication tag.
Validation
Local Bash boundary tests pass (including failed run value, malformed input, lower and upper bounds). After review/merge to beta, dispatch a new Beta APK build on the exact merge SHA and verify APK metadata, signer, artifact upload and update-in-place from the previously installed Beta. No merge or release requested in this PR.