Repository navigation
fix(ui): keep Modern Library badges and search text readable - #45
Merged
Merged
Conversation
Noirero
marked this pull request as ready for review
November 15, 2026 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern Library badges can obscure or truncate counts on dense cards at large font sizes, and built-in Modern search text is vertically clipped by decoration padding inside its 44dp surface.
Measure badge groups at their natural widths before constraining them. Move overflow above the cover, wrap badges and long badge text, and retain the image ratio, fixed/adaptive columns, callbacks, palette and authored shapes. Other badge consumers keep their single-line default. Remove duplicate padding from built-in Modern search and allow its minimum height to grow with text.
Render fixtures now provide the application's content color and text style. Comfortable fixtures include both badge groups. Add coverage for large counts, long language labels, empty badges, complete text layout, image ratio and click behavior.
Local validation of the content committed as
5003bf43ad3d804c3c5d6a4d3cc9df1b90c4ba5d:spotlessApplyandspotlessCheck: PASS.:app:compileDebugKotlinand:app:compileDebugAndroidTestKotlin: PASS.AnimeModernThemeIntegrationTest: 88 PASS, zero failures, errors or skips.Ten Android instrumentation cases are included in this PR; instrumentation was not run locally for the current commit.
CI on the current commit: run 43677019393, attempt 2 is successful.
Keep this PR Draft. Paired APK before/after screenshots, effective app navigation/inset measurements, full-route traversal and physical-device testing remain outstanding. Component goldens do not establish visual parity or merge readiness. Production sheet and Browse divider code are unchanged. No cross-screen rollout, CI workflow change or release version allocation is included.