Skip to content

fix(ui): keep Modern Library badges and search text readable - #45

Merged
Noirero merged 2 commits into
betafrom
feat/beta-modern-p0-evidence
Nov 15, 2026
Merged

Noirero merged 2 commits into
betafrom
feat/beta-modern-p0-evidence

Conversation

@Noirero

@Noirero Noirero commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Modern Library badges can obscure or truncate counts on dense cards at large font sizes, and built-in Modern search text is vertically clipped by decoration padding inside its 44dp surface.

Measure badge groups at their natural widths before constraining them. Move overflow above the cover, wrap badges and long badge text, and retain the image ratio, fixed/adaptive columns, callbacks, palette and authored shapes. Other badge consumers keep their single-line default. Remove duplicate padding from built-in Modern search and allow its minimum height to grow with text.

Render fixtures now provide the application's content color and text style. Comfortable fixtures include both badge groups. Add coverage for large counts, long language labels, empty badges, complete text layout, image ratio and click behavior.

Local validation of the content committed as 5003bf43ad3d804c3c5d6a4d3cc9df1b90c4ba5d:

  • spotlessApply and spotlessCheck: PASS.
  • :app:compileDebugKotlin and :app:compileDebugAndroidTestKotlin: PASS.
  • Targeted theme/Library tests plus AnimeModernThemeIntegrationTest: 88 PASS, zero failures, errors or skips.
  • Includes 44 native Robolectric API 35 render cases and exact verification of 48 neutral PNG goldens with recording disabled.
  • Eight existing grid frames remain pixel-identical.
  • Diff and staged whitespace checks: PASS; staged bytes match the validated patch.

Ten Android instrumentation cases are included in this PR; instrumentation was not run locally for the current commit.

CI on the current commit: run 43677019393, attempt 2 is successful.

  • Code Quality & Tests: PASS.
  • Production Restore Integration (Android): PASS; 42 tests finished on the API 35 emulator.
  • The first attempt failed while packaging the presentation-core test APK, before instrumentation ran. Re-running the failed Android job on the same commit succeeded; no code or CI workflow change was needed for the retry.

Keep this PR Draft. Paired APK before/after screenshots, effective app navigation/inset measurements, full-route traversal and physical-device testing remain outstanding. Component goldens do not establish visual parity or merge readiness. Production sheet and Browse divider code are unchanged. No cross-screen rollout, CI workflow change or release version allocation is included.

@Noirero
Noirero marked this pull request as ready for review November 15, 2026 07:04
@Noirero
Noirero merged commit 2aeb8b3 into beta Nov 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants