Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8ed1967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused tests, fixture refactor, or release note; tests were not executed.
No open issues 🎉
What changed in this PR
Adds regression coverage for EIP-8037 gas fields exposed by the tracing dependency upgrade, without changing EDR runtime logic.
Changes:
- Tests Amsterdam gas dimensions in default traces and transaction
callTracerresponses. - Checks that EIP-8037 fields remain absent before Amsterdam and extracts a shared test fixture.
- Adds a release note describing the tracing response fields.
| File | Description |
|---|---|
crates/edr_provider/tests/integration/eip8037.rs |
Adds gas-dimension and pre-Amsterdam omission tests, with shared fixture helpers. |
.changeset/debug-trace-gas-dimensions.md |
Documents the Amsterdam tracing response additions. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/amsterdam-revm-upgrade #1885 +/- ##
==============================================================
Coverage ? 81.02%
==============================================================
Files ? 474
Lines ? 84026
Branches ? 84026
==============================================================
Hits ? 68085
Misses ? 13657
Partials ? 2284 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6f65a24 to
c8673e2
Compare
Assert against expected gas_state and reservoir for SSTORE opcodes
👀 Targets the
feat/amsterdam-revm-upgradefeature branch, notmainValidates the EIP-8037 side of the revm 43 bump #1847 on the
debug_trace*responses.revm-inspectors 0.43fills the EIP-8037 gas fields thatalloy-rpc-types-tracedefines, and EDR returns theGethTraceas is, sodebug_traceTransactionanddebug_traceCallnow report them from Amsterdam on with no EDR code change:executionGasUsed,stateGasUsed,gasRefundstructLogsentry:stateGasReservoir, and a signedstateGasCoston steps that charge or refill state gascallTracer, root call frame:executionGasUsed,stateGasUsed,gasRefundThe fields are gated on the spec and skipped when absent, so responses before Amsterdam are byte-identical to the current ones.
The
stateGasTracerbuilt-in also works through EDR; it is not gated and reports zero state gas before Amsterdam.API naming considerations 👀
EDR follows alloy's field names. At the time of writing they differ from the execution-apis proposal (ethereum/execution-apis#852) in
executionGasUsed, which the proposal callsregularGasUsed; the proposal is still open, so alloy may adopt it down the road.