Skip to content

feat: EIP-8037 gas dimensions in debug_trace* (Amsterdam) - #1885

Merged
Wodann merged 6 commits into
feat/amsterdam-revm-upgradefrom
feat/8037-propagate-gas-fields-in-traces
Oct 26, 2026
Merged

Wodann merged 6 commits into
feat/amsterdam-revm-upgradefrom
feat/8037-propagate-gas-fields-in-traces

Conversation

@anaPerezGhiglia

@anaPerezGhiglia anaPerezGhiglia commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

👀 Targets the feat/amsterdam-revm-upgrade feature branch, not main


Validates the EIP-8037 side of the revm 43 bump #1847 on the debug_trace* responses.

revm-inspectors 0.43 fills the EIP-8037 gas fields that alloy-rpc-types-trace defines, and EDR returns the GethTrace as is, so debug_traceTransaction and debug_traceCall now report them from Amsterdam on with no EDR code change:

  • default tracer, top-level frame: executionGasUsed, stateGasUsed, gasRefund
  • default tracer, each structLogs entry: stateGasReservoir, and a signed stateGasCost on steps that charge or refill state gas
  • callTracer, root call frame: executionGasUsed, stateGasUsed, gasRefund

The fields are gated on the spec and skipped when absent, so responses before Amsterdam are byte-identical to the current ones.

The stateGasTracer built-in also works through EDR; it is not gated and reports zero state gas before Amsterdam.

API naming considerations 👀

EDR follows alloy's field names. At the time of writing they differ from the execution-apis proposal (ethereum/execution-apis#852) in executionGasUsed, which the proposal calls regularGasUsed; the proposal is still open, so alloy may adopt it down the road.

@changeset-bot

changeset-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8ed1967

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in the focused tests, fixture refactor, or release note; tests were not executed.

No open issues 🎉

What changed in this PR

Adds regression coverage for EIP-8037 gas fields exposed by the tracing dependency upgrade, without changing EDR runtime logic.

Changes:

  • Tests Amsterdam gas dimensions in default traces and transaction callTracer responses.
  • Checks that EIP-8037 fields remain absent before Amsterdam and extracts a shared test fixture.
  • Adds a release note describing the tracing response fields.
File Description
crates/​edr_provider/​tests/​integration/​eip8037.rs Adds gas-dimension and pre-Amsterdam omission tests, with shared fixture helpers.
.changeset/​debug-trace-gas-dimensions.md Documents the Amsterdam tracing response additions.

Review effort: Balanced

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/amsterdam-revm-upgrade@84f8ebd). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/amsterdam-revm-upgrade    #1885   +/-   ##
==============================================================
  Coverage                               ?   81.02%           
==============================================================
  Files                                  ?      474           
  Lines                                  ?    84026           
  Branches                               ?    84026           
==============================================================
  Hits                                   ?    68085           
  Misses                                 ?    13657           
  Partials                               ?     2284           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from build/upgrade-revm-43 to feat/amsterdam-revm-upgrade October 22, 2026 16:17
@anaPerezGhiglia
anaPerezGhiglia force-pushed the feat/8037-propagate-gas-fields-in-traces branch from 6f65a24 to c8673e2 Compare October 22, 2026 16:28
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 16:28 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia marked this pull request as ready for review October 22, 2026 16:28
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 17:32 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 17:32 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 14:51 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 14:54 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 14:54 — with GitHub Actions Inactive
Assert against expected gas_state and reservoir for SSTORE opcodes
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 15:43 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 15:46 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 15:46 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 19:37 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 20:06 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 23, 2026 20:06 — with GitHub Actions Inactive
@Wodann
Wodann merged commit 43c7246 into feat/amsterdam-revm-upgrade Oct 26, 2026
63 checks passed
@Wodann
Wodann deleted the feat/8037-propagate-gas-fields-in-traces branch October 26, 2026 14:49

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants