Repository navigation
Conversation
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 05:48 — with
GitHub Actions
Inactive
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
- Coverage 81.77% 81.77% -0.01%
==========================================
Files 475 475
Lines 85145 85145
Branches 85145 85145
==========================================
- Hits 69626 69625 -1
Misses 13226 13226
- Partials 2293 2294 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 06:17 — with
GitHub Actions
Inactive
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 06:17 — with
GitHub Actions
Inactive
Wodann
force-pushed
the
test/debug-trace-struct-log-fields
branch
from
November 17, 2026 07:36
14d5f77 to
cfa6168
Compare
Wodann
had a problem deploying
to
github-action-benchmark
November 17, 2026 07:36 — with
GitHub Actions
Error
Wodann
force-pushed
the
test/debug-trace-struct-log-fields
branch
from
November 17, 2026 07:36
cfa6168 to
387ed76
Compare
Wodann
had a problem deploying
to
github-action-benchmark
November 17, 2026 07:36 — with
GitHub Actions
Error
No test rejected a struct log field outside the spec's StructLog schema. A field that revm-inspectors or alloy added would pass every test. EDR serialises the struct log verbatim, so it would reach every consumer. The new test traces a call into a loop that runs out of gas, with memory and return data enabled. Its steps carry all eleven StructLog fields. The test asserts that no step has any other field. It also asserts that the steps together have every field, so an empty or partial trace cannot pass it. The trace's top-level fields are pinned to the OpcodeTransactionTrace set.
Wodann
force-pushed
the
test/debug-trace-struct-log-fields
branch
from
November 17, 2026 07:38
387ed76 to
418f1c0
Compare
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 07:38 — with
GitHub Actions
Inactive
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 07:40 — with
GitHub Actions
Inactive
Wodann
temporarily deployed
to
github-action-benchmark
November 17, 2026 07:40 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests of #1907 check that the required
StructLogfields are present and that three named fields are absent by default, but none rejects a field outside the spec's schema. A field that alloy or revm-inspectors adds would pass every test and reach every consumer of the trace. This PR adds the test the review of #1907 asked for.What changes
crates/edr_provider/src/requests/debug/tests/edr.rstraces a call into a loop that runs out of gas, with memory and return data enabled. It asserts that the trace has exactly theOpcodeTransactionTracefields, that every step has onlyStructLogfields, and that the steps together carry all eleven of them, so an empty or partial trace cannot pass it.Validation
Removing
errorfrom the pinned set and injecting amemSizekey into one step each make the test fail, with the offending key and step in the message.Notes for review
stateGasCostandstateGasReservoirfields deliberately, and theeip8037integration tests already pin them.