Skip to content

Port ignition-ui tests from Mocha to node:test - #8867

Merged
kanej merged 1 commit into
mainfrom
port-ignition-ui-tests-from-mocha-to-node
Nov 20, 2026
Merged

kanej merged 1 commit into
mainfrom
port-ignition-ui-tests-from-mocha-to-node

Conversation

@kanej

@kanej kanej commented Nov 20, 2026

Copy link
Copy Markdown
Member

Convert over Ignition UI's single test file from mocha to node:test.

Some deps and helper files go. The scripts in package.json to run tests and coverage update.

Run the to-mermaid tests under node --test with the repo's test reporter,
using the template package's test, test:only and test:coverage scripts.
Swap chai for node:assert/strict, nyc for c8, and drop the now unused
Mocha and chai dependencies and the .mocharc.json and .nycrc files.

ignition-ui now runs under node --test, so test:file can run it.
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b5ea54d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

hardhat

Total size of the bundle: 42M
Total number of dependencies (including transitive): 38

List of dependencies (sorted by size)
33M	total
7.3M	@sentry/core
5.2M	zod
3.8M	micro-eth-signer
2.2M	undici
2.2M	@noble/curves
1.8M	@noble/hashes
1.5M	@nomicfoundation/hardhat-utils
1.1M	@noble/ciphers
884K	@nomicfoundation/hardhat-vendored
792K	@streamparser/json
700K	@nomicfoundation/hardhat-errors
536K	@scure/bip39
508K	ethereum-cryptography
504K	tsx
468K	micro-packed
408K	json-stream-stringify
320K	enquirer
320K	@nomicfoundation/hardhat-zod-utils
312K	semver
216K	adm-zip
208K	@scure/base
204K	ws
188K	@streamparser/json-node
168K	esbuild
160K	fast-equals
156K	@nomicfoundation/edr
108K	@scure/bip32
100K	chokidar
80K	p-map
72K	@nomicfoundation/solidity-analyzer
56K	rfdc
48K	ansi-colors
44K	resolve.exports
44K	readdirp
24K	strip-ansi
24K	is-safe-filename
24K	env-paths
24K	ansi-regex

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Ignition UI migration to Node’s built-in test tooling.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Migrates Ignition UI’s single test suite from Mocha to node:test, aligning it with the repository’s shared reporter and file-level test tooling.

Changes:

  • Switches tests to Node’s built-in test and assertion APIs.
  • Updates test scripts, adds focused-test support, and replaces nyc coverage with c8.
  • Removes obsolete configuration and dependencies, and enables Ignition UI in test:file.
File Description
scripts/​test-file.ts Enables file-level test execution for Ignition UI.
pnpm-lock.yaml Synchronizes dependencies with the new test tooling.
packages/​ignition-ui/​tsconfig.json Replaces Mocha global types with Node types.
packages/​ignition-ui/​test/​to-mermaid.ts Uses node:test and node:assert/strict.
packages/​ignition-ui/​package.json Updates test and coverage commands and dependencies.
packages/​ignition-ui/​.nycrc Removes obsolete nyc configuration.
packages/​ignition-ui/​.mocharc.json Removes obsolete Mocha configuration.

Review effort: Balanced

@kanej kanej added no changeset needed This PR doesn't require a changeset no docs needed This PR doesn't require links to documentation no peer bump needed labels Nov 20, 2026
@kanej
kanej added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 0325d07 Nov 20, 2026
256 of 259 checks passed
@kanej
kanej deleted the port-ignition-ui-tests-from-mocha-to-node branch November 20, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset no docs needed This PR doesn't require links to documentation no peer bump needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants