chore: setting up project (cont) - #2
Open
cameronolivier wants to merge 6 commits into
Open
Conversation
…ry, adding PropTypeUtils and setting onOfOptions for Category of StoryCategoryIntro prop
jon-nona
reviewed
Aug 28, 2019
|
|
||
| export const lightBlue = '#23A5DD' | ||
| export const blue = '#007AFF' | ||
| export const blueDark = '#2269A3' |
Contributor
There was a problem hiding this comment.
Is this going to be the same for every project?
Contributor
Author
There was a problem hiding this comment.
these can be removed - was keeping in the off-chance we needed it for within the components - but I think best to just remove altogether - only need black and dark grey I think
I can do a cleanup now or in a new PR?
Contributor
There was a problem hiding this comment.
I think could you remove what you don't want here and push a commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Done
chore: adding React and React-Native as devDeps and peerDeps
chore: fixing up storybook components
chore: removed DevInfoPane component for now (doesn't add much utility atm)
refactor: moved the Storybook Constants into its own file.
refactor: moved all colors into individual exports to easier see which color is being used.
refactor: moved all Storybook components into individual folders with index.js for exports.
feat: brought in
utils/propTypes.utils.js.