fix: unbreak GH Pages build (linkHealth dynamic import) - #6
Merged
Conversation
Pre-recruiters-view WIP: improves dashboard sort behavior by date-first, priority-second. Adds sourceDate tracking on leads so the home page shows most-recent searches at the top regardless of P-tier within a session. Removes the duplicate Up Next + Recent Applications grid section that was already represented elsewhere.
… is empty
GH Pages CI was failing because Rollup statically tried to resolve
./generated/link-health.json even though the existing import was wrapped
in a try/catch. The generated/ dir is intentionally gitignored, so the
file is never present in CI, and the static analysis blocks the build
before the catch can run.
Replace bare dynamic import() with import.meta.glob, which evaluates to
{} at build time when no files match — restoring the optional-load
semantics the try/catch was originally trying to express.
Verified locally with bun run build both WITH and WITHOUT the generated
file present.
Same pattern as linkHealth fix. The 10 try/catch-wrapped dynamic imports of ./personal/* files were failing Rollup's static resolution at build time even though the catch was meant to make them optional. CI deploys don't have the gitignored personal/ files, so the build broke after the linkHealth fix removed the first failure. Replace bare dynamic imports with a single import.meta.glob lookup. If the file isn't present, the glob entry is undefined and we skip cleanly. Verified locally with bun run build both WITH and WITHOUT src/lib/data/personal/ present.
NooRotic
added a commit
that referenced
this pull request
May 21, 2026
fix: unbreak GH Pages build (linkHealth dynamic import)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits, both targeting main:
`fix(linkhealth): use import.meta.glob so build passes when generated/ is empty` (the actual hotfix)
`feat(dashboard): sort leads and Up Next by source date, then priority` (carryover, pre-existing local WIP)
If you'd rather review/merge these separately, just say — happy to split.
Verification
🤖 Note: GH Pages was already broken on `main` since commit `1e6c0d7` (2026-04-27), pre-dating PR #5. The recruiters PR did not introduce the regression.