Repository navigation
Conversation
The Library→CAM→Run pipeline becomes traversable end to end for the first time since the Direct Carve yank. Project Plan carve stages already routed operation items to the CAM window; the window now does something with that context. Activating a carve operation records the parent model as the CAM panel's active setup (name + resolved mesh path). The panel gains a machine choice fed from the engine's /api/machines, a Generate G-code action, a job status line, and a Send to Run handoff. Generation runs the sidecar off the UI thread (ensureReady + submitJob on a worker, results marshaled through MainThreadQueue), building a default rough+finish surfacing JobSpec from the new pure cam::buildDefaultSurfacingJobSpec builder. The returned G-code persists exactly the way Direct Carve used to save programs: atomic write into the project directory, G-code library record with prepared-document statistics, and a Generated project item parented to the carve operation — so the existing Run boundary consumes it unchanged. Send to Run activates that item and opens the sender. Engine start is now async as well, removing the accepted ~10s UI-thread freeze from the Phase 2 placeholder. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The default JobSpec sent meshes in their authored orientation, so a Z-up model like a standing dagger got roughed as concentric rings around its vertical silhouette instead of carved from above. The CAM panel gains an Orientation choice defaulting to lay-flat: the app picks the engine axisSwap (none/yz/xz) that minimizes the resulting Z height from the model's stored bounds, with explicit overrides available. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Answers the 'we cannot just make G-code without knowing the basics' feedback. The CAM panel now shows Clearing tool and Finishing tool choices backed by the .vtdb tool database through a new pure cam::toEngineTool projection (Vectric geometry + cutting data -> engine ToolSpec, with imperial->metric and rate_units->mm/min conversion and stepover as a diameter fraction). Auto policy picks the largest flat endmill for clearing and a ball nose no coarser than it for finishing; the hardcoded 6mm/3mm pair remains only as a labeled fallback when the library has nothing usable. The machine combo is now labeled Post-processor and explains itself before the engine has listed machines, and the generation status line names the tools and orientation used, so a run is never a mystery: "Generating toolpaths... Tools: X clearing, Y finishing; laid flat". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Which windows exist in which workspace mode, and what an open request does about a mismatch, were spread across enforceWorkspaceBoundary and openWindow as inline role checks. core/config/window_mode_policy now owns both rules: windowAvailableInMode (Workshop->Model, Sender->CNC, everything else spans both) and windowOpenAction (cross-mode requests switch the workspace, an active stream pins it, the Library overlay blocks Sender windows). WorkspaceMode moves next to the rules it governs; UIManager consumes the policy instead of encoding it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
First slice of the workflow re-architecture: the Library → Project → CAM → Run pipeline is traversable start to finish for the first time since the Direct Carve yank.
/api/machines, Generate G-code, live job status, and Send to Run.ensureReady+submitJobon a worker thread, results marshaled throughMainThreadQueue. Engine start is async too, removing the accepted ~10s UI-thread freeze from Phase 2.cam::buildDefaultSurfacingJobSpecbuilder (unit-tested); tooling values are placeholders until Phase 4 projects real.vtdbtools.Generatedproject item parented to the carve operation — the unchanged Run boundary consumes it like any other program. Send to Run activates the item and opens the sender across the workspace boundary.direct_carvekeys so existing projects resume).Deliberate gaps (next slices)
No toolpath preview in the viewport yet, no per-operation parameter editors (Phase 5), and
openWindowstill refuses handoffs while the Library overlay is open.Verification
Full build + 1499 tests green; bridge bundles under bun; the identical default spec shape passes the packaging smoke end-to-end against a live engine payload.
🤖 Generated with Claude Code