Update dotnet.yml#104
Merged
NorthernLight1 merged 7 commits intomainfrom Apr 29, 2026
Merged
Conversation
- Add N.EntityFramework.Extensions.MySql targeting net9.0 with Pomelo.EntityFrameworkCore.MySql 9.0.0 - Add N.EntityFramework.Extensions.MySql.Test with Testcontainers.MySql 4.11.0 - Add N.EntityFramework.Extensions.MySql.runsettings - Update solution file with both new MySQL projects MySQL-specific implementation details: - MySqlBulkCopy for bulk insert via MySqlConnector (transitive via Pomelo) - JOIN-based UPDATE/DELETE syntax for MERGE operations - information_schema queries using DATABASE() for table/column checks - CREATE TABLE ... AS SELECT ... WHERE 1=0 for CloneTable - AUTO_INCREMENT reset via ALTER TABLE ... AUTO_INCREMENT = 1 - No schema concept (GetDefaultSchema returns null) - Uses EF Core 9 SetPropertyCalls<T> API for UpdateFromQuery Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use MySqlBuilder(image) constructor to avoid obsolete API warning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Reorder operations to UPDATE -> DELETE -> INSERT (was UPDATE -> INSERT -> DELETE) so newly inserted rows are not immediately deleted by the subsequent DELETE when MergeOnCondition uses nullable columns - Fix deleteJoinCondition to use matchJoinCondition when mergeOnCondition is not null (was incorrectly guarded by preallocatedIds flag) - Use SELECT COUNT(*) before UPDATE to get matched-row count, since MySQL ExecuteNonQuery returns rows-changed not rows-matched by default - Add staging table index (ALTER TABLE staging ADD INDEX idx_pk) after CloneTable when keepIdentity=true to prevent async timeout on large datasets - Fix TPT RowsInserted aggregation: use FirstOrDefault() instead of Sum() since each TPT table independently inserts the same N rows (Sum doubled the count for 2-table TPT hierarchies) - Add UseAffectedRows=false to MySQL connection string (belt-and-suspenders) All 12 BulkSync tests now pass (was 8 failing). The 6 With_Transaction failures and 2 With_Transaction skips are pre-existing MySQL limitations: CREATE TEMPORARY TABLE causes an implicit DDL commit, so bulk operations inside an explicit transaction cannot be rolled back. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.