delete unimplemented method prototype secondstime() - #107
Open
IowaDave wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible duplication of remarks uploaded previously.
This PR deletes lines 47-48 in DS3231.h where a DateTime class method named "secondstime()" is prototyped. Line 47 is a comment relating to this prototype.
I do not find the prototype implemented, nor any other instance of the string "secondstime" in DS3231.cpp. It appears to be a thought that someone had at some time in the past, to give the DateTime class two methods for returning a timestamp, where the timestamps could have different numerical values, one counting from year 1970 and the other from year 2000. However, it was not completed.
I would pursue deletion of the prototype for two, other reasons also. Firstly, incompatible return type. Its return value is typed "long", a signed value, which is inconsistent with the usage of uint32_t elsewhere in the Library. Secondly, redundant. Documentation explains how the value returned by the unixtime() method relates to the Library's design constraint of dates only between 2000 and 2099, inclusive.