Repository navigation
fix(data): hardware for the Switch and the Redmi 9A family - #65
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
Two devices with no hardware list, which matters more once a ROM-wide fact lands on them (I'm about to add fingerprint for LineageOS and crDroid).
The Switch pages (
nxandnx_tab) are nowhardware: [], like the handhelds in #61. The LineageOS wiki lists no modem, fingerprint reader or NFC for any of the four Switch models, and there's nothing NFC or fingerprint in the device tree. The Switch Lite does have an amiibo reader, but LineageOS has no NFC support for it, so n/a still fits.blossomis crDroid's one build for the whole Redmi 9A family. Its tree asserts dandelion, angelica, angelican, cattail and angelicain, and the README maps those to the 9A, 9AT, 9i, 9C, 9C NFC, 9 Activ, 10A and POCO C3/ C31. The page just said "Redmi 9A", so a 9C owner searching for theirs found nothing. It now has those names plus their model numbers from MobileModels, the chips (Helio G25 on the 9A, G35 on the 9C, per GSMArena) and 2020. Hardware is the union, same as other mutli-variant pages: the 9C has a rear fingerprint reader and the 9C NFC adds NFC.Issue Number
None
Additional Info
Three active Switch rows go to n/a for calls, 5G, eSIM, NFC, fingerprint and Wallet. Validate, tests and build pass.