Repository navigation
feat(data): what LineageOS and crDroid's rules say has to work - #66
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
feature-status
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
What works
Overview
LineageOS's device support requirements say what an official build has to support before it ships: NFC wherever stock had it, the fingerprint reader on phones that came with Android 6 or later, and every audio output stock had, Bluetooth included (aptX is only a "should"). Anything that doesn't work has to be listed on the device's wiki page, which is where the quirks the import already reads come from, and there's no fingerprint or Bluetooth quirk. So those three go in
roms/lineageos.ymlas inferred, which shows as "Likely works". The NFC quirk still wins on the four old Samsungs that have it.crDroid's rules say the same for the fingerprint reader and every stock audio output, so those two go in
roms/crdroid.yml. They don't mention NFC.I've left camera alone, as both only promise the camera works, not that it's as good as stock, which is what that column is asking. Evolution X and PixelOS don't have per-feature rules (just "stable for daily usage").
Issue Number
None
Additional Info
On active rows, fingerprint unknowns go from 874 to 503, NFC from 822 to 548 and Bluetooth audio from 940 to 540. The charter only covers Oreo onwards, so the 115 ended LineageOS 13/ 14.1 rows pick these up too - they still say "Likely", but that bit's a strech. Validate, tests and build pass.