Repository navigation
fix(data): merge the duplicate Redmi Note 12 Pro 5G pages - #67
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
The Redmi Note 12 Pro 5G had two pages, same story as the Note 12 5G in #44. crDroid renamed its build from
rubytorubyx, so the old 15.0 build sat on one page and the live one on another. Both trees assertruby,rubyx(old, new), so it's one phone.rubyis now a second codename on the rubyx page andruby.ymlis gone. Rerunning the crDroid import only drops the old row, beacuse it keeps the live build. That's the only change I took intoupstream/crdroid.yml- the rest of the rerun was newer build dates Monday will bring anyway.The rubyx page never said "Redmi" either, so searching for a Redmi Note 12 Pro found the dead page rather than the live one. It now has the Pro 5G, Pro+ 5G and Discovery Edition names plus their model numbers from MobileModels, which lists all three as
ruby.Issue Number
None
Additional Info
Validate, tests and build pass.
/devices/xiaomi/redmi-note-12-pro-5g/404s now, same as the old page did in #63.