Repository navigation
fix(data): Redmi names for the Note 12 5G and Note 11 Pro 5G - #68
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
Two Xiaomi pages that never said "Redmi" anywhere, so searching "Redmi Note 12 5G" or "Redmi Note 11 Pro" didn't list them at all (checked with the site's own search on main, they come up second with this). Search only reads the name and the aliases, and both names came in from crDroid and Evolution X as "Note 12 5G/Poco X5" and "Note 11 Pro/Poco X4 Pro".
The Note 12 5G page (gemstone) gets the Redmi Note 12 5G and Note 12R Pro names and their model numbers from MobileModels, which are sunstone and moonstone, the two the trees target (#44). It also had no chip: that's the Snapdragon 4 Gen 1 on the Redmi and the 695 on the POCO, per Xiaomi's Note 12 5G and POCO X5 5G spec pages.
The Note 11 Pro page (veux) just gets the Redmi Note 11 Pro 5G, Note 11E Pro and Note 11 Pro+ 5G names, matching the model numbers already on it.
And the Zenfone 5Z had no aliases at all, so it gets its Z01RD model number from MobileModels, plus ZS620KL like the other ASUS pages.
Issue Number
None
Additional Info
Validate passes.