Repository navigation
fix(data): NFC on the Murena phones and the P20 Pro - #69
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
NotAFlightRisk
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
The Murena One and Two showed NFC and Wallet as n/a, because /e/'s device pages leave NFC out of their peripherals. Murena's own shop pages list NFC on both (One, Two), so they've got it now. On their /e/ rows that turns NFC to unknown and Wallet to /e/'s usual broken.
The P20 Pro had it the wrong way round - eSIM but no NFC, straight from the LineageOS wiki. Huawei's spec page lists NFC and only single or dual nano SIM, and GSMArena agrees. Its LineageOS build has ended, so that one's just tidying.
I also checked the other phones the NFC gap was still unproven on (Mi 8 SE, Mi A3, Black Shark, POCO F1, Redmi Note 10, Red Magic, nubia X, Z18 mini, Zenfone Max Pro M2) and they really don't have it. GSMArena says the Max Pro M2 does, but Asus's own spec page has the NFC line commented out and the current tree has nothing NFC in it, so thats staying put.
Issue Number
None
Additional Info
Data only, validate passes.