Repository navigation
feat(data): VoLTE and VoWiFi on /e/ from Murena's shop pages - #70
Merged
Merged
Conversation
NotAFlightRisk
added
the
feature-status
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
What works
Overview
Murena sells phones with /e/OS on them, and each shop page has a spec table saying whether VoLTE and VoWiFi work on that phone ("Yes, if supported by carrier", or "Not supported by /e/OS on this phone"). That's the /e/ people saying it per phone, so it's gone in as support files for the 12 /e/ phones it covers: Fairphone 4, 5 and 6, Gigaset GS6, Murena One and Two, Pixel 5, 7 and 8, Teracube 2e, and Galaxy S9 and S9+.
Most say yes. The Teracube 2e has VoLTE but not VoWiFi, and the S9 and S9+ pages (from 2023) had neither.
androidis the /e/OS version the page states, andcheckedis the page's last-modified date (or the snapshot date where it hasn't got one). Plenty of the pages are behind on the OS version - the Pixel 7 one still says Android 13 - so nine of the 12 show as stale, which seems fair. Phones Murena doesnt sell any more link to the Wayback Machine, since their live pages 404.The HIROH, SHIFTphone 8, CMF Phone 1, Volla Tablet and Pixel Tablet pages have no VoLTE row, and the Teracube 2s isn't in /e/'s import yet, so they're left out.
Issue Number
None
Additional Info
These are the first files in
data/support/. Validate, tests and build pass, and the Fairphone 4 and S9+ pages show the answers with their "last checked" line. Unknown VoLTE and VoWiFi cells on active rows go from 762 to 750 each.