Repository navigation
feat(import): read camera quirks from the LineageOS wiki - #74
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
NotAFlightRisk
added
the
feature-status
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
What works
Overview
The LineageOS wiki has two camera quirks we weren't reading. Auxiliary cameras means the build only runs the main front and rear cameras, and external cameras means add-ons like Moto Mods don't work. Both now show the camera as partial, with a note saying which.
It's only five Motorolas - the Moto Z3, Z3 Play and Z2 Force, which are still built, plus the Z Play and Z2 Play, which aren't. Tiny, but any phone the wiki tags later gets it for free.
Issue Number
None
Additional Info
Same deal as #56: the upstream file only gets the five new cells, and the rest of a full rerun (this week's builds, one new device) can wait for Monday. The cells match what the rerun writes.
Validate, tests and build pass, and the Z3 Play, Z Play and Z2 Force pages show the notes.