Repository navigation
fix(import): keep crDroid's ZUK Z2 Plus off a Lenovo page - #79
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
scripts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Scripts
Overview
Now that two brands can share a codename (#77), the next import would give the ZUK Z2 Plus a second page. crDroid files it as "Lenovo ZUK Z2 Plus", so it'd become
lenovo/z2_plusnext to thezuk/z2_plusLineageOS and /e/ already use. A name that starts with another brand we list now goes to that brand, so crDroid's row joins the real page.It only matches a brand's own key, not the Redmi/POCO style aliases. Otherwise LineageOS's Redmi 2, which it files under Wingtech, would get a Xiaomi copy.
Issue Number
None
Additional Info
I ran the full import locally with and without this. The only difference is that one discontinued crDroid row moving from
lenovo/z2_plustozuk/z2_plus, and the five new phones still come through. Tests pass, the new one fails on the old store.