Repository navigation
feat(data): model numbers for the moto g54 5G, realme GT 2 and F(x)tec phones - #83
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
Four active phones had no model numbers, so searching for one turned up nothing, and the report bot couldn't match them either. Each comes from the build's own device tree, kept to the phones that build installs on:
The cancunf tree also has props for the moto g64 5G (XT2431), but PixelOS only names the g54, so I've left it out.
Issue Number
None
Additional Info
The Redmi 4A/5A crDroid build would want the Redmi 4A and 5A's model numbers, but the LineageOS Redmi 4A file already has them, and validate won't let two phones share one. Validate passes, and the new numbers each find their phone in search.