Repository navigation
fix(import): show iodéOS's broken 5G on the Galaxy S10 5G - #84
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
feature-status
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
What works
Overview
iodéOS's device table says no to "5G compatible?" for the Galaxy S10 5G, but the import throws every 5G "no" away. That's fair for 4G phones, where a "no" just means there's no 5G to have, and saying "broken" would beat the n/a. A phone with 5G in its name has the hardware though, so a "no" there means it doesn't work on iodéOS.
The import now marks those broken, with a note in the same style as the calls column. Today that's just the S10 5G (unknown to broken), and it'll catch any others iodé adds.
Issue Number
None
Additional Info
upstream/iodeos.ymlis a rerun of the iodéOS import, and that cell is the only change. The test for this goes red on the old import. Validate, tests and build pass.