Repository navigation
fix(import): keep a new phone's own name out of its model numbers - #89
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
scripts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Scripts
Overview
#80 stopped the import adding a phone's own name as a model number, but only for phones we already had. A brand new one still gets it. Next Monday's import adds the AYN Odin 3, and the LineageOS wiki lists its only model as "Odin 3", so its page would show "Odin 3" under "Model numbers". New devices skip that alias now too.
Issue Number
None
Additional Info
Ran the LineageOS import locally with and without this - the only difference is the Odin 3 file losing that alias. No existing device file has one. The new test case fails on the old store, everything else passes.