Removed context traits and moved settings to SurfaceSettings#72
Open
jedjoud10 wants to merge 1 commit into
Open
Removed context traits and moved settings to SurfaceSettings#72jedjoud10 wants to merge 1 commit into
jedjoud10 wants to merge 1 commit into
Conversation
Owner
|
Thanks for this. I'll test the windows build and FSR2/RT locally on my PC tomorrow. |
Contributor
Author
|
What's weird is that on my current windows machine it seems to build fine. The error in the check is that it couldn't find "ninja" to compile shaderc. |
Owner
|
Probably some changes in github actions. I'll look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't test if FSR2 or ray-tracing work, though I think it should be alright.
It passed all tests and I tried out the 01 and 02 examples and they work fine.