Skip to content

Update battle patterns and utils#19

Open
babit56 wants to merge 6 commits into
NotNite:mainfrom
babit56:more-bps
Open

Update battle patterns and utils#19
babit56 wants to merge 6 commits into
NotNite:mainfrom
babit56:more-bps

Conversation

@babit56

@babit56 babit56 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Figured it would be good to PR bp_setzoom into the library instead of just having it on my own

For possible future cases I think it would be nice to make execute_pattern and add_if_not_null public so mods can use that. Moved add_if_not_null to utils, seems like a more sensible placement when its public

@babit56 babit56 marked this pull request as draft June 18, 2026 22:05
@babit56 babit56 changed the title Add bp_setzoom in BattlePatterns and make execute_pattern public Update battle patterns and utils Jun 18, 2026
@babit56

babit56 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I actually have some more ideas now that I'm working on this (HostDT), specifically more args for some of the battle patterns and more utils for rvalues, so ill let this be a draft for a bit

@fuzzything44

Copy link
Copy Markdown
Collaborator

For possible future cases I think it would be nice to make execute_pattern and add_if_not_null public so mods can use that. Moved add_if_not_null to utils, seems like a more sensible placement when its public

I believe last time this was discussed, it was kept private intentionally because mods for the most part shouldn't need to use it; patterns they want should be available in battlepatterns instead, and if missing they should be added.

@babit56

babit56 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Seems unnecessary to me to hide it if it's just because it ideally shouldn't be needed; with how many bp's and args there are, it would surely be easier to expose the function to cover eventual edge cases?

On another note, added foreach support for LinkedList for the two relevant elements, but failed completely at implementing the interfaces like IEnumerable (so the commit message is kinda lying im realizing now) since I couldn't dereference some things and I didn't figure out how to use pointers in generics in a sensible way xD. But hey it works well enough

@babit56 babit56 marked this pull request as ready for review June 20, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants