Repository navigation
Conversation
Wpaif
force-pushed
the
fix/cpu-without-avx2
branch
from
November 8, 2026 00:09
3729a10 to
0f8fac9
Compare
The build now follows the CPU (host_march, issue 363), but the AppImage's hookshot_vk.so comes prebuilt from CI: on a CPU without AVX2 the game is built for x86-64-v2 and still stops at its start, in the renderer, after the whole build. - host_march moves, unchanged, to nx2/host_cpu.py, so make_game.py can ask it without importing build.py. - make_game.py's check_cpu stops before the game is read when HOOKSHOT_VK_PREBUILT meets a CPU without x86-64-v3, pointing to a source build (RX_MARCH set by the player skips it). - scripts/linux/appimage.sh pins the prebuilt renderer to x86-64-v3, so it no longer depends on the CI runner's CPU. - tests/test_cpu_target.py covers host_march (cpuinfo and Windows) and the check, without a game. Refs NotRexed#363 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wpaif
force-pushed
the
fix/cpu-without-avx2
branch
from
November 8, 2026 00:16
0f8fac9 to
7cd85f3
Compare
Wpaif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #363
Thanks for 2c48613: the build now follows the CPU, which covers the reporter's case (Windows builder, everything compiled locally). I reduced this PR to what that commit leaves open, and dropped my own CPU detection in favour of yours.
What is still open
The Linux AppImage's
hookshot_vk.socomes prebuilt from CI (HOOKSHOT_VK_PREBUILT). On a CPU without AVX2 the game is now built for x86-64-v2, but that renderer is still x86-64-v3, so the game stops at its start after the whole build.Change
nx2/host_cpu.py:host_march()moved there unchanged (byte-identical to 2c48613), somake_game.pycan ask it without importingbuild.py(which does work at import).build.pyimports it; itsMARCH/CPUlines are untouched.nx2/make_game.py:check_cpu()stops before the game is read, with a plain message pointing to a source build, whenHOOKSHOT_VK_PREBUILTis set and the CPU is not x86-64-v3. A player-setRX_MARCHskips it.scripts/linux/appimage.sh: the prebuilt renderer is pinned toRX_MARCH=x86-64-v3, so withhost_march()it no longer depends on the CI runner's CPU.tests/test_cpu_target.py(game-free, in source-regressions):host_march()on Haswell / Ivy Bridge / Core 2 cpuinfo, an unreadable cpuinfo, and the WindowsIsProcessorFeaturePresentpath (faked);check_cpu()stopping only for the AppImage without AVX2, and running before the game is read.Testing
python -I -B tests/test_cpu_target.py: 9/9 pass; it fails when the AppImage stop is disabled.test_cpp_preflight.pyalready fails onmain; test_cpp_preflight: take the Visual Studio route on any host #409 fixes it).If you'd rather keep
host_march()inbuild.py, I can instead havemake_game.pyimport it from there.🤖 Generated with Claude Code