Repository navigation
vulkan: initialize presentation upscaling independently of frame generation - #417
Draft
monsterlag wants to merge 1 commit into
Draft
monsterlag wants to merge 1 commit into
monsterlag wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upscaling and Sharpness silently stop working when Frame generation is Off. The direct-present path omits its
sampled view, and the scaling pipeline was initialized only by interpolation. This change forwards the direct
view under the existing replay lock and initializes only the scaler's own pipeline/sampler when filtering is
requested. Off still skips interpolation's copy/luma work, frame sets and display-thread startup.
The scaler has independent initialization/failure state, rejects invalid crop/destination dimensions, and
cleans partial image allocations without retaining stale size metadata. Initialization failure falls back to
the existing blit. No renderer API, aspect policy, decoder or game-generation change is included.
Validation prepared on main
7398e5a:Catmull, Lanczos, sharpness-only, both frame-generation environment states, all-off, cached initialization
failure/cleanup, resize allocation failure/recovery and crop clamping/recovery pass.
an explicitly source-based wiring check; the API-spy fixture does not claim GPU/lifetime validation.
For runtime verification, opt into
RX_VK_UPSCALE_LOG=1: after its first scale dispatch, the renderer logs mode,sharpness, source, requested crop and destination dimensions once. It emits no per-frame diagnostic stream.
This fixes the independently established bypass; it does not claim to fix the reported 32:9 black-screen case.
The sampled view shares the cached image's existing retirement policy. This change does not add a later presentation-fence ownership model; aggressive eviction overrides remain an inherited edge outside this fix.