Skip to content

fix: handle pyannote legacy and pre-4.x diarization return types #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NotYuSheng merged 5 commits into from
May 18, 2026
Merged

fix: handle pyannote legacy and pre-4.x diarization return types #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8073eb5
fix: handle both pyannote 4.x DiarizeOutput and legacy Annotation ret…
NotYuSheng May 18, 2026
b1b6a1a
revert: remove legacy pyannote compatibility guard
NotYuSheng May 18, 2026
5c20575
fix: truncate long speaker badge names in sidebar with ellipsis
NotYuSheng May 18, 2026
4a2931f
chore: resolve merge conflict in MeetingInfoSidebar
NotYuSheng May 18, 2026
90b2e6e
fix: use text-truncate class for speaker badge overflow
NotYuSheng May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/services/diarization_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async def diarize(self, job_uuid: str, file_path: str) -> dict:
logger.info("Diarization complete for job %s", job_uuid)

# Convert diarization to serializable format
# pyannote 4.x returns a DiarizeOutput object; itertracks is on the inner Annotation
# pyannote 4.x returns a DiarizeOutput; itertracks is on the inner Annotation
Comment thread
NotYuSheng marked this conversation as resolved.
diarization_data = {
"segments": []
}
Expand Down
9 changes: 7 additions & 2 deletions frontend/src/components/Transcript/MeetingInfoSidebar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,15 @@ export default function MeetingInfoSidebar({
</div>
<div className="info-item mb-3">
<small className="text-muted">Speakers</small>
<div className="mb-2">
<div className="mb-2 d-flex flex-wrap gap-1">
{transcript?.segments ? (
[...new Set(transcript.segments.map((s) => s.speaker))].map((speaker) => (
<Badge key={speaker} className="me-1" style={{ backgroundColor: getSpeakerColor(speaker).bg, color: getSpeakerColor(speaker).text }}>
<Badge
key={speaker}
title={speaker}
className="text-truncate"
style={{ backgroundColor: getSpeakerColor(speaker).bg, color: getSpeakerColor(speaker).text, maxWidth: '160px' }}
>
{speaker}
Comment thread
NotYuSheng marked this conversation as resolved.
</Badge>
))
Expand Down
Loading