Conversation
Notgnoshi
commented
Jan 20, 2026
Notgnoshi
commented
Jan 20, 2026
Notgnoshi
force-pushed
the
dev
branch
3 times, most recently
from
169ab29 to
4abeb8d
Compare
If the callbacks registered in self.connect_mqtt() are called before the rest of the BustlightMonitor.__init__() method has completed, they'll try to access fields (like self.status) that don't exist yet, which causes a crash.
It's too hard to get the installation correct across different Python and glibc versions, and it's not a tool I use often enough to justify getting the installation working reliably.
Notgnoshi
force-pushed
the
dev
branch
2 times, most recently
from
f8b5090 to
bc77085
Compare
$2 is not used by either of the two functions.
Notgnoshi
force-pushed
the
dev
branch
2 times, most recently
from
26abb19 to
3058740
Compare
Notgnoshi
commented
Feb 15, 2026
Notgnoshi
commented
Feb 15, 2026
Notgnoshi
commented
Feb 15, 2026
Notgnoshi
commented
Feb 15, 2026
Comment on lines
+104
to
+105
| echo "Paste is not supported via sshclip" >&2 | ||
| exit 1 |
Owner
Author
There was a problem hiding this comment.
TODO: I'd like to see if I can make clip on the local system push the contents over the tunnel to a temporary file, and then if the temporary file is present, past_sshclip can dump it to stdout.
This lets me use clip in a system() call in vim, where both stdin and stdout would be connected to a pipe.
Locally this is equivalent, but when copying from a remote tmux session that I SSH'd into with sshclip, this will copy the remote selection to my local clipboard.
This removes the need for the +clipboard feature (which removes the need for the gvim shim) and when running Vim on a remote system through sshclip, it copies to my local system's clipboard.
Notgnoshi
commented
Feb 16, 2026
| # setpriv --pdeathsig=TERM: kernel sends SIGTERM to socat when parent process dies | ||
| setpriv --pdeathsig=TERM -- \ | ||
| socat "UNIX-LISTEN:$LOCAL_SOCK,fork,mode=0600,unlink-early" \ | ||
| SYSTEM:'tmp=$(mktemp); cat > "$tmp"; clip < "$tmp" >/dev/null; rm -f "$tmp"' & |
Owner
Author
There was a problem hiding this comment.
Check for socat before trying to setup the tunnel.
Notgnoshi
commented
Feb 16, 2026
I think this only fetches from multiple remotes in parallel, and not from a single remote in parallel, but it shouldn't hurt.
There were a few issues: * Plugins overriding my unbind for MouseDragEnd1Pane * Not explicitly choosing vi mode-keys * Timing? issue resulting in mode-keys defaulting to emacs if my .bashrc on the server starts tmux vs if I start tmux manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Closes #166