fix: invalidate native lib cache by content, not size only - #30
Merged
Conversation
The generated KneRuntime only refreshed the extracted-library cache when the file size changed. A rebuilt library of identical size (e.g. after a symbol rename) kept serving stale symbols, causing UnsatisfiedLinkError. Keep the size check as a fast path and fall back to a byte comparison of the cached file against the JAR resource before trusting the cache. Fixes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
KneRuntime.loadLibrary(tier 2 JAR extract) only refreshed the on-disk cache when the extracted library file size changed. A rebuilt library of identical size (e.g. after renamingWindowsHost→NativeHost) kept serving stale symbols from the cache, causing:Changes
contentEquals) before trusting the cache.Testing
./gradlew :nna:test— full plugin suite green.