fix(repl-sdk): make {#custom-id} heading suffix actually set the id - #2219
Merged
Merged
Conversation
Previously the suffix only suppressed the auto-generated id: the custom
id was never assigned and the literal {#custom-id} stayed in the
rendered heading text, despite kolay documenting the feature as working.
Now the suffix becomes the heading id and is stripped from the text.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Aug 15, 2026
Contributor
Footnotes
|
NullVoxPopuli-ai-agent
added a commit
to gitKrystan/limber
that referenced
this pull request
Aug 15, 2026
Test-file conflict resolved by keeping the branch's headingId block and
taking main's two {#custom-id} tests in place of the 'leaves alone'
test, which asserted the pre-NullVoxPopuli#2219 skip behavior.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{#custom-id}now works as documented: the suffix becomes the heading id and is stripped from the rendered text.Before, the suffix only suppressed the auto id. Nothing assigned the custom one, and the literal
{#custom-id}stayed visible in the heading, even though kolay documents the feature as "To choose the id yourself, add{#custom-id}at the end of the heading".## A very long heading {#short-id}before:
<h2>A very long heading {#short-id}</h2>(no id at all)after:
<h2 id="short-id">A very long heading</h2>Independent of #2216 and survives its rework: this branch of
headingIdis the one piece that stays custom once auto ids move to rehype-slug, since rehype-slug skips headings that already carry an id.Tests: 2 added in
parse.test.ts(plain suffix; suffix after inline code). 60/60 across repl-sdk.🤖 Generated with Claude Code